Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add async file reads #127

Closed
belav opened this issue Apr 20, 2021 · 0 comments · Fixed by #209
Closed

Re-add async file reads #127

belav opened this issue Apr 20, 2021 · 0 comments · Fixed by #209
Labels
type:bug Something isn't working
Milestone
0.9.3

Comments

@belav
Copy link
Owner

belav commented Apr 20, 2021 •
edited
Loading

Async file reads were turned off to get the Formatting Repositories action working.
We want to re-add async file reads but implement logic to ensure only X number of files are open at a time. A SemaphoreSlim is one option for implementing this.
X is TBD.
Ditch the disable pragma on the method.
@belav belav added the type:bug Something isn't working label May 5, 2021
@belav belav added this to the 0.9.2 milestone May 5, 2021
belav added a commit that referenced this issue May 17, 2021
@belav
re-add async file reads
740a7e5 
closes #127
@belav belav mentioned this issue May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
0.9.3
Development

Successfully merging a pull request may close this issue.

re-add async file reads belav/csharpier
1 participant
@belav