Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSharpier.MSBuild does not work with dotnet watch run #228

Closed
belav opened this issue May 24, 2021 · 1 comment · Fixed by #242
Closed

CSharpier.MSBuild does not work with dotnet watch run #228

belav opened this issue May 24, 2021 · 1 comment · Fixed by #242
Labels
area:msbuild type:bug Something isn't working
Milestone

Comments

@belav
Copy link
Owner

belav commented May 24, 2021

There may be a couple problems here.
When I use CSharpier.MSBuild on one small project with dotnet watch run, it appears to get into an endless loop of formatting/triggering dotnet watch.
image
I believe this is because CSharpier writes out a file even if nothing was changed by formatting it.

When using CSharpier.MSBuild on CShapier there is a slightly different outcome which may be caused by the same problem.
image
The build errors in this come from that fact that somehow files are getting there contents changed to a single new line.

@belav belav added type:bug Something isn't working area:msbuild labels May 24, 2021
@belav
Copy link
Owner Author

belav commented May 24, 2021

We can possibly get a list of compiled items to pass to csharpier. Which will get us partly there and will make sure csharpier runs a lot faster. It might be @compile
I think we'll still have to have csharpier not write out a file if it hasn't changed.

@belav belav added this to the 0.9.5 milestone May 24, 2021
belav added a commit that referenced this issue May 30, 2021
belav added a commit that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:msbuild type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant