Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Object Creation breaking #302

Closed
belav opened this issue Jun 12, 2021 · 1 comment · Fixed by #366
Closed

Implicit Object Creation breaking #302

belav opened this issue Jun 12, 2021 · 1 comment · Fixed by #366
Milestone

Comments

@belav
Copy link
Owner

belav commented Jun 12, 2021

        private static readonly JsonSerializerOptions JsonSerializerOptions = new(
                JsonSerializerDefaults.Web
            )
            { DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull };
// should be
        private static readonly JsonSerializerOptions JsonSerializerOptions = 
            new(JsonSerializerDefaults.Web)
            {
                DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
            };
@belav
Copy link
Owner Author

belav commented Jun 14, 2021

Another related edge case

        public static TrailingComment TrailingComment(string comment, CommentType commentType) =>
            new()
            { Type = commentType, Comment = comment };
// should be
        public static TrailingComment TrailingComment(string comment, CommentType commentType) =>
            new() { Type = commentType, Comment = comment };
// or maybe
        public static TrailingComment TrailingComment(string comment, CommentType commentType) =>
            new()
            { 
                Type = commentType, 
                Comment = comment
            };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant