Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New overload for Doc.GroupWithId() #334

Closed
shocklateboy92 opened this issue Jun 21, 2021 · 0 comments · Fixed by #333
Closed

New overload for Doc.GroupWithId() #334

shocklateboy92 opened this issue Jun 21, 2021 · 0 comments · Fixed by #333
Milestone

Comments

@shocklateboy92
Copy link
Collaborator

public static Group GroupWithId(string groupId, params Doc[] contents)

should probably have another overload that takes a List<Doc>
so that we don't have instances like this:
return Doc.Concat(Doc.GroupWithId(groupId, docs.ToArray()));

where we convert a List into an Array and back into a List in the Group() constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants