Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper logging. #406

Closed
belav opened this issue Aug 20, 2021 · 0 comments · Fixed by #426
Closed

Implement proper logging. #406

belav opened this issue Aug 20, 2021 · 0 comments · Fixed by #426
Assignees
@belav
Labels
area:cli type:enhancement New feature or request
Milestone
0.10.0

Comments

@belav
Copy link
Owner

belav commented Aug 20, 2021

The console logging that used to be simple, has gotten to a point it should probably switch to a proper logger instead of using Console.WriteLine and setting console colors.

See https://github.com/dotnet/format/tree/main/src/Logging for some ideas on how to get going.
@belav belav added type:enhancement New feature or request area:cli labels Aug 20, 2021
@belav belav self-assigned this Aug 26, 2021
@belav belav added this to the 0.9.10 milestone Aug 26, 2021
belav added a commit that referenced this issue Aug 28, 2021
@belav
Making use of ILogger
d633d98 
closes #406
@belav belav mentioned this issue Aug 28, 2021
Merged
belav added a commit that referenced this issue Sep 11, 2021
@belav
Making use of ILogger (#426)
1f99049 
* Making use of ILogger

closes #406

* Self code review

* And that is why we validate PRs

* Improve formatting of exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belav belav

Labels
area:cli type:enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Making use of ILogger belav/csharpier
1 participant
@belav