Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.csharpierignore causes csharpier to be significantly slower #594

Closed
belav opened this issue Feb 6, 2022 · 1 comment · Fixed by #597
Closed

.csharpierignore causes csharpier to be significantly slower #594

belav opened this issue Feb 6, 2022 · 1 comment · Fixed by #597
Labels
priority:high
Milestone
0.15.0

Comments

@belav
Copy link
Owner

belav commented Feb 6, 2022

Formatting csharpier-repos now takes 60 minutes.
#581 #580 or #575 are the most likely ones to have caused the problem.
@belav belav added this to the 0.15.0 milestone Feb 6, 2022
@belav belav mentioned this issue Feb 6, 2022
Merged
@belav
Copy link
Owner Author

belav commented Feb 6, 2022

I narrowed this down to the fact that I added a .csharpierignore file to csharpier-repos.
It isn't actually 0.15.0 that it is slow, it is that a .csharpierignore file significantly slows down csharpier.

@belav belav changed the title 0.15.0 seems significantly slower .csharpierignore causes csharpier to be significantly slower Feb 6, 2022
belav added a commit that referenced this issue Feb 7, 2022
@belav
Drastically speed up formatting when ignore or config file exist.
56c4953 
closes #594
@belav belav mentioned this issue Feb 7, 2022
Merged
@belav belav closed this as completed in #597 Feb 8, 2022
belav added a commit that referenced this issue Feb 8, 2022
@belav
Drastically speed up formatting when ignore or config file exist. (#597)
a338a6c 
closes #594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:high
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Drastically speed up formatting when ignore or config file exist. belav/csharpier
1 participant
@belav