Better support for dotnet commands. #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JSanchezIO I made changes to hopefully remove any PATH issues from Rider. VSCode was having PATH issues for some users, possibly because it never got the changes you had made to Rider. When updating Rider with similar changes I was reminded that you had fixed the PATH issues on OSX. If you have a chance, would you be able to make sure https://github.com/belav/csharpier/releases/tag/rider-1.6.0-beta works on OSX? Everything is good on windows, and I have an Ubuntu setup I can test them on. |
|
Tested this on ubuntu and I believe it is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use RiderDotNetActiveRuntimeHost to find the path to the dotnet exe, and sets DOTNET_ROOT where appropriate. This should remove any need for the PATH to be correct.
closes #893