Add DevelopmentDependency property to CSharpier.MsBuild.csproj
#607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, awesome project, thanks for your work!
This package only runs in `BeforeTargets="Build"` right? I just tested installing the MsBuild package like this (with PrivateAssets attr), in a global `Directory.Build.Props` file, and it seems to work:
```csproj
<ItemGroup>
<PackageReference Include="CSharpier.MsBuild" Version="0.15.0" PrivateAssets="all" />
</ItemGroup>
```
Usecase being we have some packages that are going to be published, and we only need `csharpier` during build (doesnt need to be a dep of the package).
|
Btw, this should also add the |
|
Thanks for reporting this. I did find that when CSharpier.MsBuild is a DevelopmentDependency, it ends up in the csproj like this StyleCop.Analyzerz does the same thing. |
belav
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Woah... @belav beat me to a review 😮 Australia time-zone is having some disadvantages.
Thanks for your contribution @martinothamar !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, awesome project, thanks for your work!
This package only runs in
BeforeTargets="Build"right? I just tested installing the MsBuild package like this (with PrivateAssets attr), in a globalDirectory.Build.Propsfile, and it seems to work:Usecase being we have some packages that are going to be published, and we only need
csharpierduring build (doesnt need to be a dep of the package).