Better lambda indent #673
Merged
Better lambda indent #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
approved these changes
May 22, 2022
| return; | ||
| } | ||
| ); | ||
| someObject.CallMethod(lambdaWithBlock => |
There was a problem hiding this comment.
Is this really "better"? IMHO the previous version was more readable for both these cases.
There was a problem hiding this comment.
I think it is mostly better, with those examples being the ones that fall into "maybe not better" category.
These examples I think are definitely better. It saves vertical space and I don't think it is any less readable there.
belav/csharpier-repos@831f201#diff-bc2e3864cdf7b47541cca4aa46b6d378cb2c11cb0091dca0647fed8a565a7dbf
It indents less too, which helps in other cases like this
belav/csharpier-repos@831f201#diff-668431d269a33a846504a3895822785838e4d92a10e9a3ce025b37de65724ed2
fwiw, prettier formats it like this. I don't really like that they force ( ) on it
someObject.CallMethod((lambdaWithBlock) => {
return;
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the simple cases, #672 will take care of some more complex cases.
closes #669