Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks compatible target framework #797

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Checks compatible target framework #797

merged 3 commits into from
Jan 17, 2023

Conversation

samtrion
Copy link
Contributor

Checks if a compatible target framework is used. If not, .NET 7 is used.

This prevents error messages like the following.

C:\Users\<username>\.nuget\packages\csharpier.msbuild\0.22.0\build\../tools/csharpier/netstandard2.0/dotnet-csharpier.dll  C:\sources\Test1\src\Console1" exited with code 1.

Checks if a compatible target framework is used. If not, .NET 7 is used.
@belav
Copy link
Owner

belav commented Jan 17, 2023

Ah crap, I forgot about this! I meant document that CSharpier_FrameworkVersion was required if your project wasn't targeting net6 or net7, but this is a better idea.
Although maybe it should default to net6, which is what 0.21.0 auto selected. But it's also pretty easy for someone to add this property and point to net6 (after I document that it exists, which I forgot to do).
I'm kinda leaning keep it at net7, but let me know your thoughts. I can push out a release for this tomorrow.

@belav
Copy link
Owner

belav commented Jan 17, 2023

Ah, I take it back. I did document this, but still, auto selecting this is the better option and helps avoid any confusion for people updating.

@samtrion
Copy link
Contributor Author

I chose the solution because it is simply the most compatible to seem. Since it also handles a possible misconfiguration of CSharpier_FrameworkVersion.

With the question net6.0 or net7.0 as default value, it was simply a decision for the performance of net7.0.

@belav belav merged commit df4754b into belav:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants