Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send to MPV player using context menu not opening video #16

Open
GoodGuyNick opened this issue Oct 3, 2018 · 4 comments
Open

Send to MPV player using context menu not opening video #16

GoodGuyNick opened this issue Oct 3, 2018 · 4 comments

Comments

@GoodGuyNick
Copy link

GoodGuyNick commented Oct 3, 2018

If try to open second video here(Steins;Gate 0 Episode 23 Ending Song | Gate of Steiner by Eri Sasaki), mpv will not open. mpv will start trying to open link but then just quits. The same goes if you try to open this video from recommended sections. It will only work if opening video and pressing button from toolbar.
I don't have this issue with Open With.

@belaviyo
Copy link
Owner

belaviyo commented Oct 4, 2018

What is your browser and what is your OS?
So if you use the toolbar button it works just fine but the context menu causing the external player to be closed? Do you have --keep-open=yes in the command-line options? Also try to open the player first and then try to send the links to the player using this extension.

@GoodGuyNick
Copy link
Author

Ubuntu 18.04, Firefox 62.0.3.

So if you use the toolbar button it works just fine but the context menu causing the external player to be closed?

yes

Do you have --keep-open=yes in the command-line options?

no

My config:

--hwdec=vaapi
--ytdl-format=bestvideo[height<=?1080]+bestaudio/best
--player-operation-mode=pseudo-gui
--ontop
--geometry=--0--0
--autofit=25%
--save-position-on-quit
--sub-pos=0
--alang=eng,en,english, en-GB, en-US
--slang=eng,en,english, en-GB, en-US
--sub-scale=0.6
--idle=no

While I was testing your addon I disabled and enabled it multiple times and now I don't have it in context menu. Uninstalling and installing native-messaging-hosts helped. I had not encountered this issue with Open With.

Also try to open the player first and then try to send the links to the player using this extension.

It opens second instance of mpv with "No file"

@belaviyo
Copy link
Owner

belaviyo commented Oct 8, 2018

In the options page of the extension add --keep-open=yes to the command-line and see if it helps.

While I was testing your addon I disabled and enabled it multiple times

This is an error with Firefox's start-up event. Just close the browser and reopen it for the items to appear.

@GoodGuyNick
Copy link
Author

In the options page of the extension add --keep-open=yes to the command-line and see if it helps.

Not working.

Just close the browser and reopen it for the items to appear.

I did this before and it was not working for some reason but now it is working.

Why do you asking me for testing? On your setup there is no problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants