Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated order constants to current api standard #27

Closed

Conversation

leonardogcsoares
Copy link
Contributor

Some constants weren't compatible with the arguments required for the API call.

@Glavic
Copy link
Contributor

Glavic commented Oct 11, 2017

This constants are used when parsing "Get recent trades" response; where you get <buy/sell> result as b or s. Check it out here: https://api.kraken.com/0/public/Trades?pair=XETHZEUR
You can see that even tests fail...

@leonardogcsoares
Copy link
Contributor Author

Yup, makes sense! Sorry =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants