Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase typescript strictness #482

Merged
merged 5 commits into from
Jul 22, 2023

Conversation

belgattitude
Copy link
Owner

Add by default

    "strict": true,
    "useUnknownInCatchVariables": true,
    "noImplicitOverride": true,
    "noUncheckedIndexedAccess": true,
    "allowUnreachableCode": false,
    "noFallthroughCasesInSwitch": true,
    "strictNullChecks": true,

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

🦋 Changeset detected

Latest commit: e107ba8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@httpx/dsn-parser Patch
@httpx/exception Patch
@httpx/json-api Patch
@examples/nextjs-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Jul 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #482 (9366bbe) into main (091cad0) will not change coverage.
The diff coverage is n/a.

❗ Current head 9366bbe differs from pull request most recent head e107ba8. Consider uploading reports for the commit e107ba8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          60       60           
  Lines         408      408           
  Branches       59       59           
=======================================
  Hits          381      381           
  Misses         24       24           
  Partials        3        3           
Flag Coverage Δ
httpx-exception-unit 93.38% <ø> (ø)
Impacted Files Coverage Δ
packages/exception/src/base/HttpException.ts 100.00% <ø> (ø)

@belgattitude belgattitude merged commit 5337e61 into main Jul 22, 2023
8 checks passed
@belgattitude belgattitude deleted the increase-typescript-strictness branch July 22, 2023 16:52
@belgattitude belgattitude mentioned this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant