-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: API #6
Conversation
Also migrated to Vue3 (as Vue2 is EoL for a while now).
Backend changes
There are still some TODOs open:
@loganwilliams Some further UX improvements seem possible to me, but would require knowing more about how it's used - e.g. do people use the small previews more than the main map? |
Thanks for this @zameji, really appreciate your work here. It will take me some time to review it, and I might ask you to break the PR into smaller feature specific chunks. I'll be in touch soon. Best, |
Sure, take your time. Breaking it up is going to be somewhat problematic though, esp. in the frontend, since the migration to Vue3 brought with it a lot of necessary changes. |
Thanks @zameji, I understand that it might be hard to break up changes. As a first pass, to separate PR concerns, could you make one PR for front-end changes and one PR for back-end changes? |
Sure @loganwilliams I'll look into that tonight / tomorrow night. |
Closing this PR as:
|
This escalated a bit, main changes: