Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Post editing issues #585

Closed
vaniver opened this issue Sep 29, 2016 · 6 comments
Closed

Post editing issues #585

vaniver opened this issue Sep 29, 2016 · 6 comments

Comments

@vaniver
Copy link
Contributor

vaniver commented Sep 29, 2016

It looks like lesswrong.com/submit gives a 404 when editing a post that's supposed to go to Main (with admin on). It's likely this is related to PR 575.

@jglamine
Copy link
Contributor

I'll take a look at this now.

@jglamine
Copy link
Contributor

I'm able to reproduce this locally.

Editing of articles is broken, both on main and discussion.
Submission to main works fine.

@jglamine
Copy link
Contributor

Found it.

The bug was caused by a JavaScript error. When the page loads, it tries to add some help text to the "url" filed. But on the edit page there is no "url" field. So it throws an exception and never binds the onSubmit handler for the form.

That's why it's posting to /submit instead of making an xhr request to /api/submit.

@vipulnaik
Copy link

I see you have a commit fixing the issue; but I still can't edit old posts. Is the commit just awaiting deployment, or is there more debugging you need to do?

@jglamine
Copy link
Contributor

Still waiting on deployment. I'd recommend watching PR #586 if you want to be notified when it's deployed.

@wezm wezm closed this as completed in #586 Oct 4, 2016
@wezm
Copy link
Contributor

wezm commented Oct 4, 2016

Fix deployed. Sorry about the delay we had a public holiday then I was off sick.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants