Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator identitas #58

Merged
merged 14 commits into from Oct 8, 2021
Merged

Operator identitas #58

merged 14 commits into from Oct 8, 2021

Conversation

Dikihmd01
Copy link
Contributor

@Dikihmd01 Dikihmd01 commented Oct 7, 2021

Deskripsi (Description)

Menambahkan operator identitas

Checklist:

Umum:
  • Saya menambah algoritma terbaru.
  • Saya memperbaiki algoritma yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi (Basic/operator/README.md).
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.
Unit Testing dan Linting:
  • pytest
  • flake8

Environment

Saya menggunakan (I'm using):

  • os = windows
  • python = py -3 -V (Windows-Python launcher)

linked issue #32

Copy link
Member

@athallahmaajid athallahmaajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coba masnya lihat disini

disana ada beberapa trailing whitespace, mohon dihapus trailing whitespace nya ya mas

dan juga mohon gunakan linter yang sudah disediakan, contoh: flake8

@Dikihmd01
Copy link
Contributor Author

Ok mas. Makasih.
Aku coba lagi

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 7, 2021

This pull request introduces 4 alerts when merging b575ac0 into a79134d - view on LGTM.com

new alerts:

  • 4 for Comparison using is when operands support `__eq__`

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 7, 2021

This pull request introduces 4 alerts when merging 9b5bcc1 into a79134d - view on LGTM.com

new alerts:

  • 4 for Comparison using is when operands support `__eq__`

Copy link
Member

@slowy07 slowy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

penggunaan operator identitas lebih disarankan menggunakan fungsi logika seperti pada contoh dibawah ini

a = 2
b = 3
if a is b:
 print("sama")
elif a is not b:
 print("tidak sama")

contoh kedua

a = 4
if (type(a) != int):
  print("bukan bilangan integer)
else:
  print("bilangan integer")

@Dikihmd01
Copy link
Contributor Author

Ok, Mas. Aku update lagi.

Basic/operator/operator_identitas.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nomadkode nomadkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs aman. LGTM 🚀
Terima kasih @Dikihmd01 sudah berkontribusi pada repo Python di bellshade. 👍🏻

@Dikihmd01
Copy link
Contributor Author

Halo mas @slowy07
Apakah masih ada yang harus diperbaiki?

Copy link
Member

@slowy07 slowy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, terima kasih atas kontribusinya @Dikihmd01

@slowy07 slowy07 merged commit 60eab17 into bellshade:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants