Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Napa to CircleCI #241

Merged
merged 9 commits into from Dec 3, 2015
Merged

Move Napa to CircleCI #241

merged 9 commits into from Dec 3, 2015

Conversation

darbyfrey
Copy link
Contributor

@bellycard/platform

@ochagata We use CircleCI for everything else at Belly, but we haven't moved Napa over yet - now seems like a good time.

@ochagata
Copy link

ochagata commented Dec 2, 2015

Sounds good. I would still love to see the CI running the rubocop check though. @darbyfrey

@heymackey
Copy link
Contributor

👍 for CircleCI (once passing), though you might need to find a way to tell it not to run rake db:create (thinks its a rails app). I think you can do that using override as discussed here: http://blog.joshsoftware.com/2013/12/18/overriding-circleci-settings-to-load-data-from-seed-and-rake-tasks/

machine:
ruby:
version:
2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nitpick, new line

@darbyfrey
Copy link
Contributor Author

@danielmackey build is green now

@ochagata want to update your PR to run rubocop once I merge this in?

If I can get a +1 I'll merge this one in right away

@heymackey
Copy link
Contributor

+1 from me.

@ochagata
Copy link

ochagata commented Dec 2, 2015

@darbyfrey Yeah, I'll need to add an exclude for vendor. It included it and started running rubocop for all gems. I'll make the commit tomorrow

@ochagata
Copy link

ochagata commented Dec 2, 2015

@darbyfrey Might need to change the config on either github or travis to make the builds stop, since the last commit had a failed build due to a missing .travis.yml

@ashtonthomas
Copy link
Contributor

@ochagata it's just to put us in the mood for Christmas 🎄

;-)

@ochagata
Copy link

ochagata commented Dec 2, 2015

@ashtonthomas

darbyfrey added a commit that referenced this pull request Dec 3, 2015
@darbyfrey darbyfrey merged commit 17c0f46 into bellycard:master Dec 3, 2015
@darbyfrey darbyfrey deleted the circleci branch December 3, 2015 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants