Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go and toolset version and run formatter #18

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

kk-no
Copy link
Member

@kk-no kk-no commented Mar 15, 2023

What to do

  • Fix lint error in master branch.
  • Update Go version to use io.ReadAll.
  • Update linter and formatter version.

Acceptance criteria

@kk-no kk-no added bug Something isn't working enhancement New feature or request labels Mar 15, 2023
@kk-no kk-no requested review from ttyfky, hatakoya, sn1w and dys6 March 15, 2023 08:45
@kk-no kk-no self-assigned this Mar 15, 2023
on: push
on:
push:
pull_request:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ci job was not started in PR from fork.

Copy link
Member

@ttyfky ttyfky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kk-no kk-no merged commit bf87cc8 into main Mar 15, 2023
@kk-no kk-no deleted the upgrade-go-version branch March 15, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants