Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Homebrew formula #1

Closed
beltex opened this issue Sep 16, 2014 · 8 comments
Closed

Create Homebrew formula #1

beltex opened this issue Sep 16, 2014 · 8 comments

Comments

@beltex
Copy link
Owner

beltex commented Sep 16, 2014

Update

  • Formula is ready to go. See Gist
  • Whoever would like to submit to Homebrew, feel free to do so!
  • As the project author, I can't :)
  • Keep in mind though, there is no guarantee that it will be accepted, as it may not be popular enough, etc., which is totally cool.
@beltex
Copy link
Owner Author

beltex commented Nov 24, 2014

@beltex
Copy link
Owner Author

beltex commented Jan 1, 2015

Good ref - https://github.com/thoughtbot/homebrew-formulae

Could just create a tap like above.

@RSully
Copy link

RSully commented Jan 19, 2015

👍 homebrew formula. If I have any free time I'll see about making one, but don't let me hold anyone else back from giving it a go.

@beltex beltex added the tools label Aug 20, 2015
@beltex
Copy link
Owner Author

beltex commented Aug 20, 2015

With #21 complete we now have a proper Makefile and building from command line smoothly. So I put together an initial formula in a Gist. Used SourceKitten, Carthage, (both Swift based tools) and htop-osx formulae as reference. Passes brew audit dshb --online --strict. A few notes on it.

  • Pointing to the custom source code archive rather than the git tag. This way, don't need to grab the other submodules when building, so the checksum holds more value. Think its a more secure way to go about things. And since the main Homebrew tap requires tagged releases anyway, this approach is fine as we'll continue to generate such archives for every release (or if Source code archives are missing Git submodules #29 is addressed it'll be done for us)
  • As opposed to a prefix install, just doing make release, and then moving the binary and manual page in place in the formula (via bin.install & man1.install commands). This takes care of the Homebrew prefix for us
  • Not much we can do for the test requirement, did the same thing that htop-osx formula does, booting and passing q as input to quit and asserting success. Beyond that, all I can think of is running -v or -h and checking the output. Is there something better that can be done?
  • I'm not sure how to express the fact that dshb supports OS X 10.9, yet Mavericks can't officially build it because Xcode 6.3.2 doesn't support it (really it's Xcode.app that doesn't, the Swift compiler that comes bundled should work fine). Two options I can see for that. One is when Swift goes open source later this year, folks can get there hands on Swift independent of Xcode and thus the formula could instead depend on the Swift compiler version instead of Xcode. Alternatively, could have the bottle (Homebrew parlance for binary) be used in that case, with no option to build from source (though I'm not sure the Homebrew build bot will accept that).

@RSully Take a look and let me know what you think!

/cc @Eownis who I noticed is running a personal Homebrew tap with a dshb formula - nice! :)

@titouanco
Copy link

@beltex Thanks, this is my first brew formula so it's not perfect but it works for me. I'm just waiting for a new release that works with Xcode 7 to use the release tag instead of commit id.

@beltex
Copy link
Owner Author

beltex commented Aug 23, 2015

this is my first brew formula

Same!

I'm just waiting for a new release that works with Xcode 7 to use the release tag instead of commit id.

Cool!

@beltex
Copy link
Owner Author

beltex commented Sep 4, 2015

Alright folks, I think the formula is good to go! The last point about 10.9 support can be brought up with the Homebrew team. Whoever would like to submit, feel free to do so. As the project author, I can't :) Keep in mind though, there is no guarantee that it will be accepted, as it may not be popular enough, etc., which is totally cool.

@beltex
Copy link
Owner Author

beltex commented Jan 26, 2016

Done! :)

$ brew update
$ brew install dshb

🎉

@beltex beltex closed this as completed Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants