Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor #38

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Appveyor #38

merged 2 commits into from
Jan 3, 2018

Conversation

jschueller
Copy link
Collaborator

@giraldeau
Copy link
Collaborator

  • Indeed, defining MUPARSER_DLL is important on Windows.
  • MUPARSERLIB_EXPORTS was defined twice, fixed
  • The DEBUG definition was inverted, fixed (but should it be _DEBUG?)

@giraldeau giraldeau merged commit 6390bc2 into beltoforion:master Jan 3, 2018
@giraldeau
Copy link
Collaborator

Awesome, thanks for this patch. Appveyor is up and running.

https://ci.appveyor.com/project/giraldeau/muparser/build/1.0.1

@giraldeau
Copy link
Collaborator

And kudo for CMAKE_INSTALL_LIBDIR, better than LIB_SUFFIX.

@jschueller jschueller deleted the appveyor branch January 3, 2018 07:45
@jschueller jschueller mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jschueller @giraldeau