Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A github.com/apache/thrift/lib/go/thrift update is causing this go drive to fail #111

Closed
betjens opened this issue Jul 16, 2020 · 2 comments

Comments

@betjens
Copy link

betjens commented Jul 16, 2020

Hello Team,

On june 15th, "github.com/apache/thrift/lib/go/thrift" recenlty updated its file. Causing file hiveserver.go to fail. Just curious if this Its been addressed at the moment? . I'm Kind of nubbie, so maybe a workaround exist for it at the moment?.

thrift update - link: apache/thrift@e79f764#diff-8a01e4124163225974263ecb577e8bf4
affected file: https://github.com/beltran/gohive/blob/master/hiveserver/HiveServer.go

error:

.....\go\src\github.com\beltran\gohive\hiveserver\HiveServer.go:1125:32: not enough arguments in call to oprot.WriteFieldStop
       have ()
       want (context.Context)
......\go\src\github.com\beltran\gohive\hiveserver\HiveServer.go:1128:32: not enough arguments in call to oprot.WriteStructEnd
       have ()
       want (context.Context)
......\go\src\github.com\beltran\gohive\hiveserver\HiveServer.go:1128:32: too many errors

Regards,

@betjens
Copy link
Author

betjens commented Jul 16, 2020

I just solved this issue by using an older version of thrift.

@betjens betjens closed this as completed Jul 16, 2020
@beltran
Copy link
Owner

beltran commented Jul 16, 2020

Thank you for brining this to my attention. I wasn't aware of that commit and it's actually pretty good news and a good feature. Looks like they haven't released a release yet with that commit but once that happens we should take advantage of it.

The reason you were seeing that failure is because you didn't have the right thrift version in go.mod, you could've update it with go get github.com/apache/thrift@23c8e52 and it would've worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants