Bug fix: asyncio.cancel #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beormund
commented
Nov 20, 2022
Beormund
commented
- Replaced asyncio.cancel with task.cancel and now storing tasks in self.conns instead of handlers.
- Check web server is running before shutting down and is not running before starting.
- Removed unused self.processed_connections in webserver class.
Adds ability to specify multiple parameter names in restful urls. Adds ability to obtain query string as a dictionary from request object.
Fix greedy matching of url root. Now _find_url_handler has to match path and params for parameterized urls.
Changed params['_param_names'] to params['_param_count']. Also made further improvements to path/param detection in _find_url_handler.
No need for this helper method to be async.
Replaced asyncio.cancel calls with task.cancel and removed unused processed_connections count. Also, self.conns[hid] = handler is now self.conns[hid] = task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.