Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no auto bower install #228

Merged
merged 1 commit into from
Apr 25, 2018
Merged

no auto bower install #228

merged 1 commit into from
Apr 25, 2018

Conversation

kompolom
Copy link
Member

No description provided.

@awinogradov
Copy link
Member

Why is it a problem?

@tadatuta
Copy link
Member

@awinogradov

Why is it a problem?

it's a library which can be used on a project without bower (where all the deps are installed with npm for example). library should not dictate anything.

@tadatuta
Copy link
Member

@kompolom this is a useful PR but libs should be installed in travis environment to run tests

@belozer
Copy link
Member

belozer commented Feb 16, 2018

@kompolom ping

@kompolom kompolom force-pushed the v1.0.0 branch 3 times, most recently from 6bf6429 to 605fe2e Compare March 9, 2018 18:33
@kompolom
Copy link
Member Author

kompolom commented Mar 9, 2018

@awinogradov @tadatuta fixed! Now we run npm run deps before travis starts specs.

@belozer
Copy link
Member

belozer commented Apr 24, 2018

@awinogradov ping

@tadatuta tadatuta merged commit 8599226 into bem-contrib:v1.0.0 Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants