BemCell.create method #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
force-pushed
the
qfox.feat-create
branch
from
907ae01
to
27a9014
Compare
skad0
reviewed
Jan 27, 2017
| @@ -191,6 +192,40 @@ BemCell.isBemCell(cell); // true | |||
| BemCell.isBemCell({}); // false | |||
| ``` | |||
|
|
|||
| ### #create(object) | |||
There was a problem hiding this comment.
а что означает # перед названием?
There was a problem hiding this comment.
Статический метод. Можно как-то иначе их обозначать, это такое.
skad0
requested changes
Jan 27, 2017
README.md
Outdated
|
|
||
| Creates BemCell instance by the any object representation. | ||
|
|
||
| Helper for laziness. |
test/create.test.js
Outdated
| }); | ||
|
|
||
| test('should create BemCell for block from obj', t => { | ||
| const data = { block: 'b', elem: 'e' }; |
There was a problem hiding this comment.
зачем тут элемент? Да и кажется переменная не требуется (как в тесте ниже)
| }); | ||
|
|
||
| test('should create cell with tech', t => { | ||
| const cell = BemCell.create({ block: 'block', tech: 'css' }); |
There was a problem hiding this comment.
надо еще добавить тест про BemCell.create({ entity, tech, layer })
qfox
force-pushed
the
qfox.feat-create
branch
from
27a9014
to
dadc777
Compare
Yeti-or
reviewed
Jan 31, 2017
README.md
Outdated
| @@ -191,6 +192,40 @@ BemCell.isBemCell(cell); // true | |||
| BemCell.isBemCell({}); // false | |||
| ``` | |||
|
|
|||
| ### #create(object) | |||
|
|
|||
| Creates BemCell instance by the any object representation. | |||
Yeti-or
reviewed
Jan 31, 2017
index.js
Outdated
| @@ -211,4 +211,42 @@ module.exports = class BemCell { | |||
| static isBemCell(cell) { | |||
| return cell && this.name === cell.constructor.name; | |||
| } | |||
|
|
|||
| /** | |||
| * Creates BemCell instance by the any object representation. | |||
Yeti-or
requested changes
Jan 31, 2017
| * @param {string} obj.block — the block name of entity. | ||
| * @param {string} [obj.elem] — the element name of entity. | ||
| * @param {object|string} [obj.mod] — the modifier of entity. | ||
| * @param {string} obj.mod.name — the modifier name of entity. |
There was a problem hiding this comment.
no, it's not if obj.mod is an object
index.js
Outdated
| * // BemCell { block: 'my-button', mod: { name: 'theme', val: 'red' }, tech: 'css' } | ||
| */ | ||
| static create(obj) { | ||
| if (BemCell.isBemCell(obj)) { |
There was a problem hiding this comment.
To prevent creating BemCells from BemCells
qfox
force-pushed
the
qfox.feat-create
branch
from
dadc777
to
63dafcd
Compare
Yeti-or
approved these changes
Feb 1, 2017
skad0
approved these changes
Feb 1, 2017
qfox
force-pushed
the
qfox.feat-create
branch
from
63dafcd
to
620e74d
Compare
qfox
force-pushed
the
qfox.feat-create
branch
from
620e74d
to
65e4cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Yeti-or @blond @tadatuta
Blocked by bem-sdk-archive/bem-entity-name#72
Closes #12