This repository has been archived by the owner on Feb 4, 2018. It is now read-only.
feat: add toJSON method for good stringify #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skad0
reviewed
Oct 7, 2016
| * | ||
| * @returns {*} | ||
| */ | ||
| toJSON() { |
There was a problem hiding this comment.
When I call method toJSON I expect to have a json here. This method should be getData maybe.
There was a problem hiding this comment.
It's for JSON.stringify
There was a problem hiding this comment.
Why not to call JSON.stringify here if this is only for such purpose.
There was a problem hiding this comment.
I can't use this class with JSON.stringify without this method, sorry. It should return raw data, not string.
blond
reviewed
Oct 8, 2016
blond
suggested changes
Oct 8, 2016
| @@ -222,6 +222,14 @@ module.exports = class BemEntityName { | |||
| return `BemEntityName ${stringRepresentation}`; | |||
| } | |||
| /** | |||
| * Return raw data for JSON.stringify. | |||
| * | |||
| * @returns {*} | |||
There was a problem hiding this comment.
Why *?
this._data has the schema:
/**
* @returns {{block: string, elem: ?string, mod: ?{name: ?string, val: *}}}
*/| * @returns {*} | ||
| */ | ||
| toJSON() { | ||
| return this._data; |
There was a problem hiding this comment.
You want add alias? Then it is better to specify it explicitly:
return this.valueOf();
|
@zxqfox I think you need to use the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @blond @kriant