fix(mod): should return `undefined` if entity is not modifier #58

blond · 2016-11-25T09:26:00Z

Closed #53

tadatuta · 2016-11-25T10:04:17Z

README.md

@@ -143,13 +143,16 @@ name.elem; // text

 The modifier of this entity.

-If entity is not modifier then returns empty object.
+**Important:** If entity is not modifier then returns `undefined`.


not a modifier (здесь и ниже)

skad0 · 2016-11-25T10:08:56Z

README.md

+const modName = new BemEntityName({ block: 'button', mod: 'disabled' });
+
+blockName.mod; // { name: 'disabled', val: true }
+modName.mod;   // undefined


Перепутан результат, у modName он будет { name: 'disabled', val: true }

skad0 · 2016-11-25T10:09:27Z

index.js

+     * const modName = new BemEntityName({ block: 'button', mod: 'disabled' });
+     *
+     * console.log(blockName.mod); // { name: 'disabled', val: true }
+     * console.log(modName.mod);   // undefined


Аналогично

fix(mod): should return undefined if entity is not modifier

9909d1c

blond added the in progress label Nov 25, 2016

blond force-pushed the issue-53 branch 2 times, most recently from fc1648b to 1f6c470 Compare November 25, 2016 09:28

tadatuta approved these changes Nov 25, 2016

View reviewed changes

skad0 approved these changes Nov 25, 2016

View reviewed changes

blond force-pushed the issue-53 branch from 1f6c470 to 286a493 Compare November 25, 2016 10:19

docs(mod): should return undefined if entity is not modifier

f0297e8

blond force-pushed the issue-53 branch from 286a493 to f0297e8 Compare November 25, 2016 10:21

blond merged commit 2690db2 into master Nov 25, 2016

blond deleted the issue-53 branch November 25, 2016 11:05

blond removed the in progress label Nov 25, 2016

blond mentioned this pull request Nov 25, 2016

bem-entity-name 1.0.0 bem-sdk-archive/meta#24

Closed

3 tasks

blond self-assigned this Nov 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mod): should return `undefined` if entity is not modifier #58

fix(mod): should return `undefined` if entity is not modifier #58

blond commented Nov 25, 2016

tadatuta Nov 25, 2016

skad0 Nov 25, 2016 •

edited

Loading

skad0 Nov 25, 2016

fix(mod): should return undefined if entity is not modifier #58

fix(mod): should return undefined if entity is not modifier #58

Conversation

blond commented Nov 25, 2016

tadatuta Nov 25, 2016

Choose a reason for hiding this comment

skad0 Nov 25, 2016 • edited Loading

Choose a reason for hiding this comment

skad0 Nov 25, 2016

Choose a reason for hiding this comment

fix(mod): should return `undefined` if entity is not modifier #58

fix(mod): should return `undefined` if entity is not modifier #58

skad0 Nov 25, 2016 •

edited

Loading