Skip to content
This repository has been archived by the owner on Feb 4, 2018. It is now read-only.

fix(error): error message more handy #77

Merged
merged 3 commits into from
Mar 31, 2017
Merged

fix(error): error message more handy #77

merged 3 commits into from
Mar 31, 2017

Conversation

Yeti-or
Copy link
Member

@Yeti-or Yeti-or commented Feb 4, 2017 •
edited by blond
Loading

2017-03-31 17 34 49

@Yeti-or Yeti-or requested review from qfox and blond February 4, 2017 17:13
qfox
qfox suggested changes Feb 5, 2017
View reviewed changes
Copy link
Contributor

@qfox qfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А где ты это поймал? в bem-cell.create?

index.js Outdated
@@ -31,7 +31,7 @@ module.exports = class BemEntityName {
*/
constructor(obj) {
if (!obj.block) {
throw new Error('This is not valid BEM entity: the field `block` is undefined.');
throw new Error(`${JSON.stringify(obj)}\nThis is not valid BEM entity: the field \`block\` is undefined.`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай util.inspect depth=1?

@blond blond changed the title Make error message more handy. fix(error): error message more handy Mar 31, 2017
@blond blond removed their request for review March 31, 2017 14:36
@blond blond merged commit b9403b8 into master Mar 31, 2017
@blond blond deleted the yeti-or.improve-err-msg branch March 31, 2017 16:14
@blond blond removed the in progress label Mar 31, 2017
@blond blond mentioned this pull request Apr 9, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qfox qfox qfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yeti-or @qfox @blond