Do not remove image's styles #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,8 +212,7 @@ function overrideLinks(content, node, urlHash, lang, doc) { | |||
|
|
|||
| content = content.replace(REGEXP.SRC, function(str, href){ | |||
| //if href is absolute (src="http://..." ) return href | |||
| href = /^http/.test(href) ? href : buildSrcForImages(href, doc); | |||
| return '<img src="' + href + '"'; | |||
| return /^http/.test(href) ? str : '<img src="' + buildSrcForImages(href, doc) + '"'; | |||
There was a problem hiding this comment.
for relative links attrs will still be dropped, isn't it?
There was a problem hiding this comment.
I am agree, looking very strange
|
@tadatuta @tavriaforever thank u, Update PR |
| @@ -155,10 +155,11 @@ function recognizeRelativeLinkForLibraryDocs(str, node) { | |||
| * @param {BaseNode} doc node | |||
| * @returns {*} | |||
| */ | |||
| function buildSrcForImages(href, doc) { | |||
| function buildSrcForImages(str, href, doc) { | |||
| var docParentUrl = doc && doc.url.replace(/\/\w*\.md/, '/'); // replace last url's part: repo/docs/a.md -> repo/docs | |||
There was a problem hiding this comment.
if there's a change that there's no doc, src will be broken
There was a problem hiding this comment.
yes, but we have no another way to know whole path to img.
|
actually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, code from bse-admin remove style for images
<p><img src="https://img-fotki.yandex.ru/get/15483/158800653.1/0_111ff6_bcf15529_orig"></p>after, we left all of attributes
<p><img style="float: right; padding: 0 0 10px 10px;" title="BEMup в Минске" alt="фотография программы с минского BEMup" src="https://img-fotki.yandex.ru/get/15483/158800653.1/0_111ff6_bcf15529_orig"></p>