BEMINFO-1380 Implement queue for link overriding #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * 3. Последовательно выполняем переопределение ссылок для каждой порции записей | ||
| * 3.1 Внутри порции переопредление ссылок для записей происходит параллельно | ||
| * 3.2 Для каждой записи страницы выбираем связанную с ней запись документа | ||
| * 3.3 Еслитаковая присутствует, то скармливаем ее content в переопределятор |
|
Судя по настройкам jscs файл с переопределением ссылок не должен был быть закоммичен - |
| } | ||
|
|
||
| return false; | ||
| }, { gte: target.KEY.NODE_PREFIX, lt: target.KEY.PEOPLE_PREFIX, fillCache: true }) |
|
а так вроде ок. |
| return getDocumentRecordsFromDb(target, changedLibVersions).then(function (records) { | ||
| logger.debug(util.format('Document records count: %s', records.length), module); | ||
| var portionSize = 100, | ||
| portions = utility.separateArrayOnChunks(records, portionSize); |
There was a problem hiding this comment.
Может не в тему PR, но почему у нас в группе так не любят lodash - https://lodash.com/docs#chunk
|
Кажется, что код создания очереди return getDocumentRecordsFromDb(target, changedLibVersions).then(function (records) {
logger.debug(util.format('Document records count: %s', records.length), module);
var portionSize = 100,
portions = utility.separateArrayOnChunks(records, portionSize);
logger.debug(util.format('Document records were divided into %s portions', portions.length), module);
return portions.reduce(function (prev, item, index) {
prev = prev.then(function () {
...
return prev;
}, vow.resolve());
});одинаковый для function overrideLinksInDocuments (target, urlsHash, languages, changedLibVersions) {и function overrideLinksInBlocks(target, urlsHash, languages, changedLibVersions) {Может его как-то инкапсулировать в отдельный метод ? |
|
А вообще очередь прикольно сделалась =) |
Да, я согласен. Но здесь особого профита не получится. |
tormozz48
added a commit
that referenced
this pull request
Aug 3, 2015
BEMINFO-1380 Implement queue for link overriding
| @@ -311,7 +312,21 @@ function overrideLinks(content, node, urlHash, lang, doc) { | |||
| return content; | |||
| } | |||
|
|
|||
| /** | |||
| * Creates url hash for resolve links | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gela-d
@SwinX
Please review it