[menu] move specific template logic which deal with menu-item's checked mod from menu to common menu_mode #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guria
changed the title
|
Why js tests could fail if all templates tests are ok? JS wasn't touched in commit. |
|
It seems that spec tests doesn't include menu_mode.bemhtml into test bundle while tmpl-specs works as expected. |
| @@ -0,0 +1,40 @@ | |||
| block('menu') | |||
| .match(function(){ | |||
| return this.ctx.mods['mode']; | |||
There was a problem hiding this comment.
I think it should be like this:
return typeof this.mods.mode !== 'undefined';
…ed mod from menu to common menu_mode iterate through content only within all menu_mode_* do it in content mode instead of def use applyNext instead of setting global ctx properties
|
@tadatuta I have resolved issue with specs tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterate through content only within all menu_mode_*
do it in
contentmode instead ofdefuse applyNext instead of setting global ctx properties
resolves #1513 #1516