Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BH 4.0 #1587

Closed
tadatuta opened this issue Jul 17, 2015 · 9 comments
Closed

Support BH 4.0 #1587

tadatuta opened this issue Jul 17, 2015 · 9 comments

Comments

@tadatuta
Copy link
Member

Should replace blockMods with mods in
common.blocks/dropdown/_switcher/dropdown_switcher_button.bh.js
common.blocks/dropdown/_switcher/dropdown_switcher_link.bh.js
common.blocks/select/__button/select__button.bh.js
common.blocks/select/__control/select__control.bh.js

@kompolom
Copy link

+1

@tadatuta
Copy link
Member Author

Misha @mishanga let's discuss the way this issue can be resolved.

Now we have such options:

  1. Update BH and drop backward compatibility in templates
  2. Update BH and support both versions in templates with mods || blockMods as suggested by @zxqfox in Adopt to BH 4.x #1588
  3. Do not update BH until bem-components 3.0

@qfox
Copy link
Member

qfox commented Jul 20, 2015

Don't go the 3rd way plx. We want to use BH4.0 with bem-components 2.x.

@mishanga
Copy link
Member

+1 for 1

@blond
Copy link
Member

blond commented Jul 20, 2015

  1. Update BH and drop backward compatibility in templates

@tadatuta @mishanga Why do you want to ignore semver recommendations? Maybe you love to hurt users?

Is there still reason to do stupid things?

  1. Update BH and support both versions in templates with mods || blockMods as suggested by

Can anyone think of reasons why not to do this?

@sipayRT
Copy link
Contributor

sipayRT commented Jul 20, 2015

@mishanga instead of @ mishaberezin ;)

@blond
Copy link
Member

blond commented Jul 20, 2015

@mishanga instead of @ mishaberezin ;)

sorry ))

@aristov
Copy link
Contributor

aristov commented Jul 23, 2015

Don't forget to remove compatibility workarounds in v3.

@qfox
Copy link
Member

qfox commented Jul 23, 2015

Yeah, need to make an issue for that.

qfox pushed a commit that referenced this issue Jul 29, 2015
qfox pushed a commit that referenced this issue Jul 29, 2015
tadatuta added a commit that referenced this issue Jul 29, 2015
qfox pushed a commit to bem/bem-components-php that referenced this issue Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants