Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox: Doesn't work in MS Edge #1590

Closed
narqo opened this issue Jul 18, 2015 · 4 comments
Closed

checkbox: Doesn't work in MS Edge #1590

narqo opened this issue Jul 18, 2015 · 4 comments
Assignees
Labels

Comments

@narqo
Copy link
Member

narqo commented Jul 18, 2015

Unfortunately b26d167 has broken the behaviour of our checkboxes, so now we have the same bug described in #1472 but in the upcoming Edge/IE11 browsers.

Note, that I've used bem-core#v2 HEAD with bem/bem-core#1066 fixies to test.

@sipayRT
Copy link
Contributor

sipayRT commented Jul 23, 2015

@narqo on an extreme case we can use IE11 hack:

@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) {
    .checkbox_theme_islands .checkbox__box
    {
        pointer-events: auto;
    }
}

it works fine for me

@narqo
Copy link
Member Author

narqo commented Jul 23, 2015

Does it work in the Edge? MSDN says:

As of Microsoft Edge, -ms-high-contrast: none is no longer supported

Do you now any CSS hack for iOS Safari only?

@sipayRT
Copy link
Contributor

sipayRT commented Jul 24, 2015

Just found mega-dirty-hack:

_::-webkit-full-page-media, _:future, :root .checkbox_theme_islands
{
    background: red !important;
}

Tested on:

  • Safari for Mac 8.0.7 (Yosemite)
  • iOS Simulator (version 8.0.3 and 8.0.4):
    • Safari on iPhone 4s
    • Safari om iPad Retina

Proof:
image

So, we can wrap pointer-events value under this hack

@narqo
Copy link
Member Author

narqo commented Jul 24, 2015

Well, one mega-dirty-hack is better than three ugly hacks. Let's switch to it (this hack for Firefox can be removed as well) and check that checkboxes work everywhere. Please add comment link with original issue about iOS and this one.

@sipayRT sipayRT self-assigned this Jul 24, 2015
sipayRT added a commit that referenced this issue Jul 24, 2015
checkbox: Doesn't work in MS Edge
@sipayRT sipayRT removed the ready label Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants