Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEMHTML: use proper boolean values for attribute #1745

Closed
tadatuta opened this issue Jan 31, 2016 · 0 comments
Closed

BEMHTML: use proper boolean values for attribute #1745

tadatuta opened this issue Jan 31, 2016 · 0 comments
Assignees

Comments

@tadatuta
Copy link
Member

Since bem/bem-xjst#183 boolean attributes are rendered as really boolean:

{ attrs: { 'aria-hidden': true } }

is now rendered without ="true" part which invalidates quite a lot of tmpl specs and as far as I understand some a11y cases, e.g.: https://github.com/bem/bem-components/blob/v2/common.blocks/popup/popup.bemhtml#L12

For aria-* cases it should be like 'aria-hidden': 'true' (fixes in templates) and for other cases (i.e. disabled: 'disabled') should be like disabled: true (fixes in templates AND specs).

@veged veged added the HTML label Feb 3, 2016
@veged veged changed the title Fix BEMHTML templates after bem-xjst update BEMHTML: use boolean values for attribute properly Feb 3, 2016
@veged veged changed the title BEMHTML: use boolean values for attribute properly BEMHTML: use proper boolean values for attribute Feb 3, 2016
gela-d pushed a commit that referenced this issue Feb 11, 2016
BEMHTML: use proper boolean values for attribute
@deeonis deeonis removed the ready label Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants