Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use touch-action: manipulation in controls #1787

Closed
narqo opened this issue Apr 5, 2016 · 1 comment
Closed

Use touch-action: manipulation in controls #1787

narqo opened this issue Apr 5, 2016 · 1 comment
Assignees
@tadatuta
Labels
CSS v3
Milestone
v3.0

Comments

@narqo
Copy link
Member

narqo commented Apr 5, 2016

As we're dropping FastClick in bem-core@v3 (see bem/bem-core#1088) we need to add touch-action: manipulation CSS rule to blocks that assume to be clicked.

After discussion \w @veged and @dfilatov we've decided that this rules must present on the top common.blocks level (e.g. not on the design/*.blocks levels).
@narqo narqo added this to the v3.0 milestone Apr 5, 2016
@narqo
Copy link
Member Author

narqo commented Apr 5, 2016

In addition to this changes we need to think about Android/WinPhone browsers.

@narqo narqo changed the title Use touch-action: manipulation in controls Use touch-action: manipulation in controls Apr 5, 2016
@tadatuta tadatuta self-assigned this Apr 18, 2016
@tadatuta tadatuta added the ready label Apr 18, 2016
tadatuta added a commit that referenced this issue Apr 20, 2016
@tadatuta
Use touch-action: manipulation in controls. Closes #1787
21f0c30
tadatuta added a commit that referenced this issue Apr 20, 2016
@tadatuta
Merge pull request #1811 from /issues/1787@v3
0917bc6 
Use `touch-action: manipulation` in controls. Closes #1787
@tadatuta tadatuta removed the ready label Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadatuta tadatuta

Labels
CSS v3
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@narqo @tadatuta