Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textarea: Resize is broken #1330 #1340

Merged
merged 1 commit into from
Feb 20, 2015
Merged

textarea: Resize is broken #1330 #1340

merged 1 commit into from
Feb 20, 2015

Conversation

hcodes
Copy link
Contributor

@hcodes hcodes commented Feb 5, 2015

No description provided.

@hcodes
Copy link
Contributor Author

hcodes commented Feb 5, 2015

/cc @mishanga

@tadatuta
Copy link
Member

tadatuta commented Feb 5, 2015

this fix just prevents from horizontal resize but in case of setting width to textarea on project level the issue is still remains :(

@hcodes
Copy link
Contributor Author

hcodes commented Feb 6, 2015

На проекте ширину нужно задавать через перекрытие .textarea, высоту через .textarea__control.
...
Другое решение, поместил resize: both c .textarea__control на .textarea, но возникли проблемы:

  • в Opera 12 пропал ресайз у textarea;
  • в Chrome и Firefox вертикальный скроллбар поменял цвет с черного на белый на MacOSX;
  • также иконка для ресайза стала накладываться на скроллбар.

...
Почему бы не добавить атрибуты cols и rows для textarea?
Для большинства случаев этого бы хватило.

@arikon
Copy link
Member

arikon commented Feb 11, 2015

@mishaberezin Нужно учесть в input2, если будет делать

@hcodes hcodes force-pushed the issues/1330@v2 branch 2 times, most recently from abcf33d to 6dd0284 Compare February 12, 2015 13:41
@hcodes
Copy link
Contributor Author

hcodes commented Feb 12, 2015

/cc @mishanga
Нужно ревью.
Удалил контейнер у textarea, теперь нет псевдоэлементов в CSS.

mishanga
mishanga reviewed Feb 18, 2015
View reviewed changes
common.blocks/textarea/textarea.bemhtml
};

ctx.autocomplete === false && (attrs.autocomplete = 'off');
ctx.mods.disabled && (attrs.disabled = 'disabled');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут не надо проверить на наличие ctx.mods?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему тут вообще ctx.mods, а не this.mods?

@mishanga
Copy link
Member

Сильно не вглядывался, но вроде ок.

@hcodes hcodes mentioned this pull request Feb 19, 2015
Closed
@hcodes
Copy link
Contributor Author

hcodes commented Feb 19, 2015

/cc @mishanga
Поправил, если больше нет замечаний, вливаю.

@narqo
Copy link
Member

narqo commented Feb 19, 2015

Squash commits before merge, plz

hcodes added a commit that referenced this pull request Feb 20, 2015
@hcodes
Merge pull request #1340 from /issues/1330@v2
b1f0f3d 
textarea: Resize is broken #1330
@hcodes hcodes merged commit b1f0f3d into v2 Feb 20, 2015
@hcodes hcodes deleted the issues/1330@v2 branch February 20, 2015 09:47
@tadatuta tadatuta mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hcodes @tadatuta @arikon @mishanga @narqo