Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] select: improve JAWS readability #1594

Closed
wants to merge 3 commits into from

Conversation

sipayRT
Copy link
Contributor

@sipayRT sipayRT commented Jul 22, 2015

Closes #1517

@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 14, 2015

try to move all aria-* attributes to select and hide __button element

@sipayRT sipayRT force-pushed the issues/1206-common@v2 branch 2 times, most recently from f77d039 to d7e0201 Compare August 17, 2015 14:15
@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 18, 2015

@aristov I moved all aria attributes to button and it looks much better now. Check it by JAWS pls

@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 21, 2015

@aristov still waiting for your review

@aristov
Copy link
Contributor

aristov commented Aug 21, 2015

I will look it today.

@aristov
Copy link
Contributor

aristov commented Aug 21, 2015

I've checked result and found out that some points of original issue are not implemented.
Try this pure HTML with JAWS, to check proper result:

<div role="listbox" tabindex="0">
    <div role="option" id="123">block</div>
    <div role="option" id="234" aria-selected="true">element</div>
    <div role="option" id="345">modifier</div>
</div>

@aristov
Copy link
Contributor

aristov commented Sep 2, 2015

Redundant "has popup" and "collapsed" phrases should be removed.

@aristov
Copy link
Contributor

aristov commented Sep 7, 2015

Close in favour of #1663

@aristov aristov closed this Sep 7, 2015
@aristov aristov removed the ready label Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants