dropdown: improve JAWS readability #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aristov need your opinion here |
|
#1393 was merged. Rebase, please. |
sipayRT
force-pushed
the
issues/1206-common@v2
branch
from
094b290
to
f77d039
Compare
sipayRT
force-pushed
the
issues/1501@v2
branch
3 times, most recently
from
068af87
to
7ab6fb4
Compare
sipayRT
force-pushed
the
issues/1206-common@v2
branch
from
f77d039
to
d7e0201
Compare
|
@aristov gemini-tests fails because of focus changing. I'll fix screenshots after your review |
| }, | ||
|
|
||
| 'true' : function() { | ||
| this._popup.domElem.attr('tabindex', 0).focus(); |
There was a problem hiding this comment.
This solution contradicts our a11y manual: https://nda.ya.ru/3Quhd7
Focus should be on button after dropdown expansion.
Let's solve focus maintaining problems later and separately from readability (#1026).
sipayRT
force-pushed
the
issues/1501@v2
branch
from
7ab6fb4
to
aa593cf
Compare
|
LGTM |
sipayRT
changed the title
sipayRT
added a commit
that referenced
this pull request
Sep 2, 2015
dropdown: improve JAWS readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1501