Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu: After disabled state tabindex has not been set #1791

Merged
merged 1 commit into from
Apr 16, 2016
Merged

Conversation

narqo
Copy link
Member

@narqo narqo commented Apr 6, 2016

fix #1767

/cc @dfilatov


Showcase is available

@narqo narqo added the ready label Apr 6, 2016
@tadatuta
Copy link
Member

tadatuta commented Apr 6, 2016

tmpl specs should be updated with this PR

@narqo
Copy link
Member Author

narqo commented Apr 15, 2016

@tadatuta I'm not sure I understand, what has happened with CI here. Could you explain, what's wrong with the specs?

@tadatuta tadatuta force-pushed the issues/1767@v2 branch 2 times, most recently from 59562a1 to 737decb Compare April 16, 2016 00:16
@tadatuta
Copy link
Member

@narqo build scrips were fixed in a674f84

So I rebased the branch and added a fix for codestyle. Guess commits should be squashed before merge.

@narqo
Copy link
Member Author

narqo commented Apr 16, 2016

Amazing!

@tadatuta
Copy link
Member

@narqo any reason not to merge?

@narqo
Copy link
Member Author

narqo commented Apr 16, 2016

It seems that tests for dist are not stable. But after I've restart the build everything looks fine.

@narqo narqo merged commit b59fb6a into v2 Apr 16, 2016
@narqo narqo deleted the issues/1767@v2 branch April 16, 2016 19:54
@narqo narqo removed the ready label Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants