Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: Write Gemini tests #648

Closed
wants to merge 75 commits into from
Closed

link: Write Gemini tests #648

wants to merge 75 commits into from

Conversation

lapinlapin
Copy link

No description provided.

@lapinlapin lapinlapin changed the title Issues/620@v2 link: Write Gemini tests Jun 16, 2014
@gela-d
Copy link
Member

gela-d commented Jun 17, 2014

Удалила пример с title, так как мы его все равно gemini не отлавливаем.

@gela-d
Copy link
Member

gela-d commented Jun 17, 2014

@arikon need review

@arikon
Copy link
Member

arikon commented Jun 17, 2014

@gela-d gemini/screens/link/normal-no-url/focused — здесь странное подчёркивание точками (не до конца ссылки)

actions.mouseDown(this.link);
})
.capture('focused', function(actions) {
actions.sendKeys(this.link, gemini.TAB);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему не mouseUp()? В этом состоянии кнопка мыши всё ещё зажата.

@gela-d
Copy link
Member

gela-d commented Jun 18, 2014

@arikon разобрались с подчеркиванием, разобрались с mouseUp.
Залила все один коммитом, глянь, пожалуйста.

@gela-d gela-d closed this Jun 23, 2014
@gela-d gela-d deleted the issues/620@v2 branch June 23, 2014 08:32
@gela-d
Copy link
Member

gela-d commented Jun 23, 2014

new PR #699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants