Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button: collapsed without given specified text (close #887) #888

Merged
merged 1 commit into from Jul 29, 2014

Conversation

dfilatov
Copy link
Member

@mishanga
Copy link
Member

It can be fixed by CSS only:

.button_theme_normal .button__text:empty:before
{
    content: '\00a0';
}

@dfilatov
Copy link
Member Author

@mishanga Does it actually depend on _theme_normal? It's not about style. Can I put this code to button__text.styl?

@mishanga
Copy link
Member

@dfilatov yep, it really does. There are several ways to fix this bug.

BTW, current bug is caused by this:

.button__text
{
display: block;
}

AFAIR .button__text { display: block } is needed just for select_width_available.

@dfilatov
Copy link
Member Author

@mishanga I've remade PR, please check

@mishanga
Copy link
Member

👍

dfilatov added a commit that referenced this pull request Jul 29, 2014
button: collapsed without given specified text (close #887)
@dfilatov dfilatov merged commit ec46c68 into v2 Jul 29, 2014
@dfilatov dfilatov deleted the issues/887@v2 branch July 29, 2014 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants