Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearfix: Refactoring needed #722

Closed
tadatuta opened this issue Nov 8, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@tadatuta
Copy link
Member

commented Nov 8, 2014

Right now we have clearfix.ie.css but we do not build ie.css bundle. So we have 2 options:

  1. Move ie.css source to common css
  2. As we do not support IE6-7 it's possible to refactor clearfix to
.clearfix:after {
    content: "";
    display: table;
    clear: both;
}

@tadatuta tadatuta added the question label Nov 8, 2014

@tadatuta

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2014

// cc @mishanga

@mishanga

This comment has been minimized.

Copy link
Member

commented Nov 9, 2014

I like second one.
But why table?

@tadatuta

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2014

@aristov

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2014

Assign an issue to yourself, if you make PR for it, please.

@veged veged added v2 and removed question labels Jan 29, 2015

@aristov aristov closed this in #727 May 14, 2015

aristov pushed a commit that referenced this issue May 14, 2015

Vyacheslav Aristov
Merge pull request #727 from /issues/722@v2
clearfix refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.