Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearfix: Refactoring needed #722

Closed
tadatuta opened this issue Nov 8, 2014 · 4 comments
Closed

clearfix: Refactoring needed #722

tadatuta opened this issue Nov 8, 2014 · 4 comments
Assignees
Labels

Comments

@tadatuta
Copy link
Member

tadatuta commented Nov 8, 2014

Right now we have clearfix.ie.css but we do not build ie.css bundle. So we have 2 options:

  1. Move ie.css source to common css
  2. As we do not support IE6-7 it's possible to refactor clearfix to
.clearfix:after {
    content: "";
    display: table;
    clear: both;
}
@tadatuta
Copy link
Member Author

tadatuta commented Nov 8, 2014

// cc @mishanga

@mishanga
Copy link
Member

mishanga commented Nov 9, 2014

I like second one.
But why table?

@tadatuta
Copy link
Member Author

tadatuta commented Nov 9, 2014

Here's an explanation: http://nicolasgallagher.com/micro-clearfix-hack/

@aristov
Copy link
Contributor

aristov commented Dec 19, 2014

Assign an issue to yourself, if you make PR for it, please.

@veged veged added v2 and removed question labels Jan 29, 2015
aristov pushed a commit that referenced this issue May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants