i-bem__dom: Fix leaking test #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| DOM.decl('block2'); | ||
|
|
||
| DOM.init(BEMHTML.apply({ | ||
| var node = $(BEMHTML.apply({ |
There was a problem hiding this comment.
в скоупе есть rootNode, которая потом afterEach дестрактится
There was a problem hiding this comment.
но мы в неё же не можем подмешать другой onSetMod.js.inited?
qfox
force-pushed
the
hotfix/i-bem-leaking-spec@v3
branch
from
a473efb
to
d01ccf2
Compare
|
|
||
| delete DOM.blocks['block']; | ||
| delete DOM.blocks['block2']; | ||
|
|
||
| res.should.be.eql([true, true]); |
There was a problem hiding this comment.
зачем res? можно проверить прямо в том месте где присваивание — всё работает синхронно
There was a problem hiding this comment.
синхронно дестракт не вызовется, потому что throw будет в случае облома.
There was a problem hiding this comment.
Хотя, это же тесты, и если оно упало — можно забить на всё остальное, потому что 1 тест это уже плохо.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found that accindentally and decide to fix.
Am I right here?
/cc @veged @dfilatov @narqo