Support bem-xjst 8.x in compatible way #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miripiruni
approved these changes
Mar 6, 2017
| @@ -1 +1,6 @@ | |||
| block('ua').js()(true); | |||
There was a problem hiding this comment.
Честно говоря, не представляю кейса, когда нужно отказаться от js:true в блоке ua…
| @@ -3,6 +3,8 @@ block('page').elem('css')( | |||
| tag()('style'), | |||
| match(function() { return this.ctx.url; })( | |||
| tag()('link'), | |||
| attrs()(function() { return { rel : 'stylesheet', href : this.ctx.url }; }) | |||
| attrs()(function() { | |||
There was a problem hiding this comment.
Кстати, не желаешь начать использовать аргументы вместо this и this.ctx здесь и в другом месте?
function(node, ctx) {
There was a problem hiding this comment.
думаю, это нужно делать одним махом везде, чтобы консистентно было.
qfox
reviewed
Feb 19, 2018
| var ctxJS = applyNext(); | ||
|
|
||
| if(ctxJS === false) return false; | ||
| return ctxJS || true; |
There was a problem hiding this comment.
А это не то же самое, что и return applyNext() !== false;?
There was a problem hiding this comment.
@zxqfox нет, вот проверочный bemjson: { block: 'ua', js: { test: 1 } }
There was a problem hiding this comment.
var res = applyNext(); return res !== false && (res || true); ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1485