Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add istanbul coverage report generation #460

Merged
merged 1 commit into from
Apr 1, 2014
Merged

Add istanbul coverage report generation #460

merged 1 commit into from
Apr 1, 2014

Conversation

narqo
Copy link
Member

@narqo narqo commented Mar 20, 2014

WIP! DO NOT MERGE!

Usage:

# Run specs and produce coverage JSON objects for future report generation
# In case of "desktop.specs" you could use any build target, 
# like "desktop.specs/button" or "desktop.specs/i-bem__dom"
› ISTANBUL_COVERAGE=yes bem make desktop.specs
....
# Generate HTML-report using coverage data produced with `bem-make`
# from previous step
› istanbul report html
› open coverage/index.html

@narqo
Copy link
Member Author

narqo commented Mar 21, 2014

\cc @dfilatov @veged @arikon
Попробовал прикрутить к coveralls.io: https://coveralls.io/r/bem/bem-core \m/_

Надо еще порефакторить: большая часть уедет в bem-pr, часть в bower-tech-istanbul

mishaberezin
mishaberezin reviewed Mar 21, 2014
View reviewed changes
.bem/borschik/istanbul.js
environ = require('bem-environ'),
instrumenter = new (require('istanbul').Instrumenter)({ preserveComments : true }),
PRJ_ROOT = environ.PRJ_ROOT,
EXCLUDE_RE = new RegExp([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без new

narqo pushed a commit that referenced this pull request Apr 1, 2014
Merge pull request #460 from bem/istanbul-cov
55ca806 
Add istanbul coverage report generation
@narqo narqo merged commit 55ca806 into v2 Apr 1, 2014
@narqo narqo deleted the istanbul-cov branch April 1, 2014 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@narqo @mishaberezin