feat(parse): should return BemEntityName object #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadatuta
approved these changes
Dec 9, 2016
| @@ -26,38 +26,74 @@ The `bem-naming` module did more than just `parse` and `stringify` BEM names. | |||
|
|
|||
| * **[major]** Removed `typeOf` method (@blond [#98]). | |||
|
|
|||
| To work with BEM entities there are packages [@bem/entity](https://github.com/bem-sdk/bem-entity) and [@bem/entity-name](https://github.com/bem-sdk/bem-entity-name). | |||
| To work with BEM entities there are packages [@bem/entity](https://github.com/bem-sdk/bem-entity) and [@bem/entity-name](https://github.com/bem-sdk/bem-entity-name). | |||
There was a problem hiding this comment.
Может вместо болдов сделать заголовки честными заголовками разного уровня и избавить от этого странного индента?
|
|
||
| [#98]: https://github.com/bem-sdk/bem-naming/issues/98 | ||
|
|
||
| * **[major]** The `parse` method returns [BemEntityName](https://github.com/bem-sdk/bem-entity-name) object (@blond [#126]). | ||
|
|
||
| It will allow use helpers of `BemEntityName`. |
|
|
||
| It will allow use helpers of `BemEntityName`. | ||
|
|
||
| **Important:** in `BemEntityName` the `modName` and `modVal` fields are deprecated. Need use the `mod` field instead ([#95]). |
|
🆙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #126
Resolved #95