Skip to content

Commit

Permalink
Fix bemhtml test by updating bem
Browse files Browse the repository at this point in the history
  • Loading branch information
Serhii Tatarintsev committed Aug 14, 2013
1 parent 8cc3840 commit e431ca8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"version": "1.0.0",
"description": "Core bem tech modules",
"scripts": {
"test": "mocha"
"test": "mocha",
"test-watch": "mocha --watch"
},
"repository": {
"type": "git",
Expand All @@ -15,13 +16,13 @@
"devDependencies": {
"mocha": "~1.12.0",
"chai": "~1.7.2",
"bem-smoke": "git://github.com/bem/bem-smoke.git#26111382f6",
"bem": "git://github.com/bem/bem-tools.git#8434c6e",
"bem-smoke": "git://github.com/bem/bem-smoke.git#3f89e45a9def",
"bem": "~0.6.15",
"sinon": "~1.7.3",
"sinon-chai": "~2.4.0"
},
"peerDependencies": {
"bem": ">= 0.6.0"
"bem": "~0.6.15"

This comment has been minimized.

Copy link
@ilyar

ilyar Feb 25, 2014

@SevInf зависимость от bem@~0.6.15 действительно обязательна, пакет bem-techs-core@~0.1.1 не совместим с bem@~0.7.0?

This comment has been minimized.

Copy link
@SevInf

SevInf Feb 25, 2014

@ilyar, версия 0.1.x должна быть совместима. Во время этого коммита 0.7.x еще не существовало и не планировалось.

This comment has been minimized.

Copy link
@tadatuta

tadatuta Feb 25, 2014

@SevInf Серега, если я правильно понимаю, то смысла использовать bem-techs-core на сегодняшний день нет: в 0.1.x нет ничего, чего бы не было в bem-bl / bem-core, а 0.2.x не доведена до продакшена и совместима только с bem-tools@1.x, которые тоже не продакшен-реди?

This comment has been minimized.

Copy link
@SevInf

SevInf Feb 26, 2014

@tadatuta, да, все верно

},
"dependencies": {
"ym": "0.0.9",
Expand Down
2 changes: 1 addition & 1 deletion test/bemhtml.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe('bemhtml.js tech', function() {
]
})
.asserts(function() {
expect(mockCompat.transpile).not.to.have.been.called();
expect(mockCompat.transpile).not.to.have.been.called;
})
.notify(done);
});
Expand Down
1 change: 1 addition & 0 deletions test/mocha.opts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
--require test/setup
--growl

0 comments on commit e431ca8

Please sign in to comment.