apply(modeName) must return values from this.ctx if no other templates
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miripiruni
force-pushed
the
issue236-apply
branch
from
f3b2df8
to
f7f6225
Compare
miripiruni
force-pushed
the
issue236-apply
branch
2 times, most recently
from
cdff1ab
to
6bc036b
Compare
|
Updated! |
| if (ctxJS !== true) | ||
| js = utils.extend(ctxJS, js); | ||
| } else if (ctxJS === true) { | ||
| js = {}; | ||
| } else { | ||
| js = ctxJS; |
There was a problem hiding this comment.
Yep. Because of this.js.exec(context) now returns this.ctx.js by default.
|
I'd put totalMix into separate commit, all the rest is LGTM |
|
@zxqfox separate commit or PR? |
|
:-D Commit will be enough to me. |
|
@zxqfox actually, |
|
May I merge? |
| @@ -18,8 +18,8 @@ function Entity(bemxjst, block, elem, templates) { | |||
| this.canFlush = true; | |||
|
|
|||
| // "Fast modes" | |||
| this.def = new Match(this); | |||
| this.content = new Match(this); | |||
| this.def = new Match(this, 'def'); | |||
miripiruni
force-pushed
the
issue236-apply
branch
from
a9be96a
to
48394cf
Compare
|
ping |
| this.cls = new Match(this); | ||
| this.tag = new Match(this, 'tag'); | ||
| this.attrs = new Match(this, 'attrs'); | ||
| this.mod = new Match(this, 'mod'); |
There was a problem hiding this comment.
Didn't noticed before, what the purpose of this? There is no mod property in bemjson as well as mod with template body. We have block('a').mod('m', 'v')(body) but not block('a').mod()(body).
There was a problem hiding this comment.
@zxqfox agree. Thank you. 'mod' removed.
|
Not sure what the |
miripiruni
force-pushed
the
issue236-apply
branch
from
48394cf
to
5460128
Compare
|
OK. |
miripiruni
force-pushed
the
issue236-apply
branch
from
91df62b
to
9d230c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #236
Benchmarks test results within the error: (+/– 1% in different bundles).