BEMHTML: Support nested mixes #280

miripiruni · 2016-05-23T19:06:06Z

This PR about only support in mix something like this:

{
    block: 'b',
    mix: [
        { block: 'a', mix: { block: 'abc' } },
        { block: 'test', mix: [ { block: 'e', js: true }, 'some-block-name', 'another-block' ] }
    ]
}

qfox · 2016-05-24T23:19:20Z

lib/bemhtml/index.js

+      out += nested.out;
+    }
+
+    // Process nested mixes from Templates


This function grows so much. I'm afraid it refused to be optimized in v8.

miripiruni · 2016-06-15T15:20:44Z

See https://github.com/bem/bem-core/blob/v2/common.blocks/i-bem/i-bem.bemhtml#L431

miripiruni · 2016-08-03T13:37:52Z

Build visited key with mods/elemMods (need sort) and cache it inside entity.
Collect out as Object (to avoid classes duplication) and then serialize.
Add tests.

miripiruni · 2016-08-11T17:18:45Z

Updated

miripiruni · 2016-08-15T16:26:43Z

@veged @zxqfox review needed.

qfox · 2016-08-24T15:45:40Z

test/bemjson-mix-test.js

+          mix: {
+            block: 'b3',
+            mods: { test: 'opa' },
+            js: { data: '123' },


А почему нет этих параметров в эталоне?

@zxqfox это ошибка, надо добавлять. Сейчас поправлю. Спасибо, что нашел!

miripiruni · 2016-08-24T16:00:54Z

Встречались с @arikon @zxqfox обсуждали JS-параметры.

Почему у примиксованного блока выводятся JS-параметры если они написаны через BEMJSON непосредственно в mix, но задать их через шаблон по моде JS нельзя.

Решили, что нужно уметь задавать JS-параметры и через BEMJSON и через шаблоны.

tadatuta · 2016-09-02T12:51:57Z

test/bemjson-mix-test.js

@@ -238,4 +238,48 @@ describe('BEMJSON mix', function() {
        'b__e_modname_modval"></div></div>');
    });
  });
+
+  describe('should support nested mixes', function() {


describe('nested mixes', function() {

it('should support nested mix', function() {

it('should support nested mix with js params', function() {

@tadatuta fixed!

coveralls · 2016-09-02T13:32:44Z

Coverage increased (+0.04%) to 96.886% when pulling d3d49d4 on issue-241__nested-mixes into d53646f on master.

miripiruni · 2016-09-05T15:18:59Z

Removed commit about #147 bacause I try to implement apply all modes from nested mix.

As long as it can benchmark penalty I decided to move it in another PR.

coveralls · 2016-09-05T15:19:20Z

Coverage increased (+0.01%) to 96.856% when pulling 9cd0e27 on issue-241__nested-mixes into d53646f on master.

miripiruni · 2016-09-05T15:21:44Z

Description updated.

coveralls · 2016-09-05T15:23:05Z

Coverage increased (+0.01%) to 96.856% when pulling 9cd0e27 on issue-241__nested-mixes into d53646f on master.

miripiruni · 2016-09-09T02:05:54Z

Looks like we need refactoring and optimize renderMix function:

d536 — current HEAD
9cd0 — nested mix branch.

coveralls · 2016-09-29T15:47:35Z

Coverage decreased (-0.1%) to 97.059% when pulling 20b8a29 on issue-241__nested-mixes into 5ab2e2f on master.

coveralls · 2016-09-29T17:15:24Z

Coverage decreased (-0.1%) to 97.063% when pulling 29233cf on issue-241__nested-mixes into 5ab2e2f on master.

coveralls · 2016-10-05T12:47:32Z

Coverage decreased (-0.1%) to 97.063% when pulling 788c06c on issue-241__nested-mixes into 5ab2e2f on master.

miripiruni · 2016-10-05T14:56:03Z

Test started…
{
  rev1: '29233cf9a03e32e06306a93b477381016559950c',
  rev2: '5ab2e2fc3d13ef95ae6c1fdd34f3cfe9f25580db',
  bemjson: 10000,
  dataPath: '/Users/miripiruni/bemjson',
  templatePath: './node_modules/web-data/templates.js',
}
Wed Oct 05 2016 17:50:49 GMT+0300 (MSK)
Total test time:  243405.277718
./lib/compare.py ./dat-29233-5ab2e ./dat-29233-5ab2e/29233cf9a03e32e06306a93b477381016559950c-10000-1475679173826.dat ./dat-29233-5ab2e/5ab2e2fc3d13ef95ae6c1fdd34f3cfe9f25580db-10000-1475679293051.dat
Percentile:  0.5
{ rev1: 8.396458,
  rev2: 7.888352,
  'diff abs': 0.5081060000000006,
  'diff percent': 6.05143263981075 }

Percentile:  0.9
{ rev1: 11.214023,
  rev2: 10.546001,
  'diff abs': 0.6680219999999988,
  'diff percent': 5.957023630145919 }

Percentile:  0.95
{ rev1: 12.401017,
  rev2: 11.752831,
  'diff abs': 0.648185999999999,
  'diff percent': 5.226877763331828 }

miripiruni · 2017-02-01T15:58:28Z

lib/bemhtml/index.js

+                                    addInit: addJSInitClass
+                                  },
+                                  null,
+                                  this.classBuilder);


this.classBuilder не нужен

miripiruni · 2017-02-01T16:05:12Z

test/bemjson-mix-test.js

+          }
+        }
+      },
+      '<div class="b1 b2__e b3 b3_test_opa b4 b5"></div>');


need test with templates on mixes

miripiruni added semver: patch status: review labels May 23, 2016

qfox reviewed May 24, 2016
View reviewed changes

miripiruni added status: in progress and removed status: review labels Jun 14, 2016

miripiruni force-pushed the issue-241__nested-mixes branch 4 times, most recently from 5a89d99 to e1a3904 Compare August 11, 2016 16:55

miripiruni added status: review and removed status: in progress labels Aug 11, 2016

miripiruni force-pushed the issue-241__nested-mixes branch 3 times, most recently from 49ea8e1 to c938dab Compare August 18, 2016 12:34

qfox reviewed Aug 24, 2016
View reviewed changes

miripiruni force-pushed the issue-241__nested-mixes branch from c938dab to 7fad99b Compare September 2, 2016 12:07

tadatuta reviewed Sep 2, 2016
View reviewed changes

miripiruni force-pushed the issue-241__nested-mixes branch from 7fad99b to d3d49d4 Compare September 2, 2016 12:53

miripiruni force-pushed the issue-241__nested-mixes branch 2 times, most recently from 2df3a84 to 9cd0e27 Compare September 5, 2016 15:16

miripiruni added 2 commits September 29, 2016 18:45

BEMHTML: Support nested mixes

e70898b

BEMHTML: nonrecursive renderMix

20b8a29

miripiruni force-pushed the issue-241__nested-mixes branch from 6f5e614 to 20b8a29 Compare September 29, 2016 15:45

BEMHTML: refactoring renderMix

788c06c

miripiruni force-pushed the issue-241__nested-mixes branch from 29233cf to 788c06c Compare October 5, 2016 12:42

miripiruni force-pushed the master branch from fe64f93 to 79b3e4e Compare December 2, 2016 12:36

miripiruni commented Feb 1, 2017

View reviewed changes

lib/bemhtml/index.js

addInit: addJSInitClass

},

null,

this.classBuilder);

Copy link

Contributor Author

miripiruni Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.classBuilder не нужен

miripiruni commented Feb 1, 2017

View reviewed changes

miripiruni closed this May 10, 2017

miripiruni removed the status: review label May 10, 2017

miripiruni mentioned this pull request May 10, 2017

BEMHTML: support nested mixes #448

Merged

miripiruni deleted the issue-241__nested-mixes branch January 29, 2018 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BEMHTML: Support nested mixes #280

BEMHTML: Support nested mixes #280

miripiruni commented May 23, 2016 •

edited

qfox May 24, 2016

miripiruni commented Jun 15, 2016

miripiruni commented Aug 3, 2016 •

edited by veged

miripiruni commented Aug 11, 2016

miripiruni commented Aug 15, 2016

qfox Aug 24, 2016

miripiruni Aug 30, 2016

miripiruni commented Aug 24, 2016

tadatuta Sep 2, 2016

miripiruni Sep 2, 2016

coveralls commented Sep 2, 2016 •

edited

miripiruni commented Sep 5, 2016

coveralls commented Sep 5, 2016 •

edited

miripiruni commented Sep 5, 2016

coveralls commented Sep 5, 2016 •

edited

miripiruni commented Sep 9, 2016

coveralls commented Sep 29, 2016 •

edited

coveralls commented Sep 29, 2016 •

edited

coveralls commented Oct 5, 2016 •

edited

miripiruni commented Oct 5, 2016

miripiruni Feb 1, 2017

miripiruni Feb 1, 2017

BEMHTML: Support nested mixes #280

BEMHTML: Support nested mixes #280

Conversation

miripiruni commented May 23, 2016 • edited

qfox May 24, 2016

Choose a reason for hiding this comment

miripiruni commented Jun 15, 2016

miripiruni commented Aug 3, 2016 • edited by veged

miripiruni commented Aug 11, 2016

miripiruni commented Aug 15, 2016

qfox Aug 24, 2016

Choose a reason for hiding this comment

miripiruni Aug 30, 2016

Choose a reason for hiding this comment

miripiruni commented Aug 24, 2016

tadatuta Sep 2, 2016

Choose a reason for hiding this comment

miripiruni Sep 2, 2016

Choose a reason for hiding this comment

coveralls commented Sep 2, 2016 • edited

miripiruni commented Sep 5, 2016

coveralls commented Sep 5, 2016 • edited

miripiruni commented Sep 5, 2016

coveralls commented Sep 5, 2016 • edited

miripiruni commented Sep 9, 2016

coveralls commented Sep 29, 2016 • edited

coveralls commented Sep 29, 2016 • edited

coveralls commented Oct 5, 2016 • edited

miripiruni commented Oct 5, 2016

miripiruni Feb 1, 2017

Choose a reason for hiding this comment

miripiruni Feb 1, 2017

Choose a reason for hiding this comment

miripiruni commented May 23, 2016 •

edited

miripiruni commented Aug 3, 2016 •

edited by veged

coveralls commented Sep 2, 2016 •

edited

coveralls commented Sep 5, 2016 •

edited

coveralls commented Sep 5, 2016 •

edited

coveralls commented Sep 29, 2016 •

edited

coveralls commented Sep 29, 2016 •

edited

coveralls commented Oct 5, 2016 •

edited