Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cycle requires while import modifiers into blocks #70

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

Yeti-or
Copy link
Member

@Yeti-or Yeti-or commented Mar 14, 2018

No description provided.

@Yeti-or Yeti-or requested a review from qfox March 14, 2018 17:10
@coveralls
Copy link

coveralls commented Mar 14, 2018

Coverage Status

Coverage increased (+1.6%) to 92.715% when pulling 3832954 on yeti-or.fix-js-cycle-deps into 83efa42 on master.

webpackModules.forEach((webpackModule, moduleIndex) => {
try {
webpackModule({}, {}, webpackRequire.bind(webpackRequire, moduleIndex));
} catch(e) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Глотаешь ошибки, эт плохо

Copy link
Member

@qfox qfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Остальное — ок

@Yeti-or Yeti-or merged commit cdac1d0 into master Mar 14, 2018
@Yeti-or Yeti-or deleted the yeti-or.fix-js-cycle-deps branch March 14, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants