Do not throw on Webpack v4 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaDiablo
approved these changes
May 26, 2018
|
Actually, it wasn't, just moved to |
|
Yeah... I think I should rename this PR to "Do not throw on webpack v4" ) To support webpack v4 we have to do way more work in tests: |
Yeti-or
approved these changes
Jul 23, 2018
|
@amje sorry for such long delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property
this.optionshas been deprecated since webpack 3. In webpack 4 it's removed completely. To support both the new version and the old ones simple check added.